Ttdfjt

Like a Baby - Riddle

What is this plant I saw for sale at a Romanian farmer's market?

Is there a term for someone whose preferred policies are a mix of Left and Right?

Leaving job close to major deadlines

How would Japanese people react to someone refusing to say “itadakimasu” for religious reasons?

Manager wants to hire me; HR does not. How to proceed?

How useful is the GRE Exam?

Can you cover a cube with copies of this shape?

How to search for Android apps without ads?

1960s sci-fi anthology with a Viking fighting a U.S. army MP on the cover

Is my research statement supposed to lead to papers in top journals?

Can a non-invertible function be inverted by returning a set of all possible solutions?

How can I ping multiple IP addresses at the same time?

What could be the physiological mechanism for a biological Geiger counter?

Redirecting output only on a successful command call

How can Caller ID be faked?

How do I become a better writer when I hate reading?

How "fast" does astronomical events happen?

What is the context for Napoleon's quote "[the Austrians] did not know the value of five minutes"?

How does the Linux command "mount -a" work?

Have Steve Rogers (Captain America) and a young Erik Lehnsherr (Magneto) interacted during WWII?

When is the phrase "j'ai bon" used?

Converting 3x7 to a 1x7. Is it possible with only existing parts?

Interview was just a one hour panel. Got an offer the next day; do I accept or is this a red flag?

Extension update - Technical submission fails

How to fix warnings / errors raised by the Magento Marketplace technical review report?Marketplace Extension RecommendationsMulti-Vendor extension for MagentoExtension Submission Expired in magento marketplaceMagento marketplace extension submission issueMagento 2 Extension submission to MarketplaceMagento 2 marketplace submission issueMagento Marketplace: After update the magento marketplace, extension stuck in “Awaiting Marketing Review”Magento 2 : Expected HIT on the second page load after product price update while Marketplace submissionCan not update the database during magento 2 module submission in marketplace

.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;

0

Magento 2.3 got CsrfAwareActionInterface, which needs to be implemented in order to be able to handle webhooks properly.

I got the following

$part = interface_exists('MagentoFrameworkAppCsrfAwareActionInterface') ? 'new' : 'old';
include_once sprintf('a/b/c/d+%s.php', $part);

In practice, this works, CsrfAwareActionInterface won't exist in Magento <2.3, but Magento's code sniffer won't agree.

It tests the code with PHP 7.1 and is successful, then it tries PHP 5.6 which has no return types, resulting in
PHP syntax error: syntax error, unexpected ':', expecting ';' or '{', telling me to fix the errors and resubmit.

Implementing the interface without compatible return types won't work.

Releasing 2 different versions (2.3 & <2.3) and supporting them wouldn't be wise, given that CsrfAwareActionInterface would be the sole difference between them.

Is the result of that test (code sniffer) breaking? Can an extension be approved despite that test failing?

extensions magento2.3 marketplace

share|improve this question

edited Jun 9 at 12:10

Ravenous

asked Jun 9 at 11:54

RavenousRavenous

1011

New contributor

Ravenous is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Which codesniff ruleset?
  
  – Dominic Xigen
  Jun 9 at 12:26
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  MEQP2.PHP.Syntax.PHPSyntax. It's not about the Code Sniffer itself, but how it's configured @ Magento marketplace level, it seems to be an acknowledged bug - github.com/magento/marketplace-eqp/issues/104
  
  – Ravenous
  Jun 9 at 12:35
  

  
  
  
  

add a comment | 

0

Magento 2.3 got CsrfAwareActionInterface, which needs to be implemented in order to be able to handle webhooks properly.

I got the following

$part = interface_exists('MagentoFrameworkAppCsrfAwareActionInterface') ? 'new' : 'old';
include_once sprintf('a/b/c/d+%s.php', $part);

In practice, this works, CsrfAwareActionInterface won't exist in Magento <2.3, but Magento's code sniffer won't agree.

It tests the code with PHP 7.1 and is successful, then it tries PHP 5.6 which has no return types, resulting in
PHP syntax error: syntax error, unexpected ':', expecting ';' or '{', telling me to fix the errors and resubmit.

Implementing the interface without compatible return types won't work.

Releasing 2 different versions (2.3 & <2.3) and supporting them wouldn't be wise, given that CsrfAwareActionInterface would be the sole difference between them.

Is the result of that test (code sniffer) breaking? Can an extension be approved despite that test failing?

extensions magento2.3 marketplace

share|improve this question

edited Jun 9 at 12:10

Ravenous

asked Jun 9 at 11:54

RavenousRavenous

1011

New contributor

Ravenous is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Which codesniff ruleset?
  
  – Dominic Xigen
  Jun 9 at 12:26
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  MEQP2.PHP.Syntax.PHPSyntax. It's not about the Code Sniffer itself, but how it's configured @ Magento marketplace level, it seems to be an acknowledged bug - github.com/magento/marketplace-eqp/issues/104
  
  – Ravenous
  Jun 9 at 12:35
  

  
  
  
  

add a comment | 

Magento 2.3 got CsrfAwareActionInterface, which needs to be implemented in order to be able to handle webhooks properly.

I got the following

$part = interface_exists('MagentoFrameworkAppCsrfAwareActionInterface') ? 'new' : 'old';
include_once sprintf('a/b/c/d+%s.php', $part);

In practice, this works, CsrfAwareActionInterface won't exist in Magento <2.3, but Magento's code sniffer won't agree.

It tests the code with PHP 7.1 and is successful, then it tries PHP 5.6 which has no return types, resulting in
PHP syntax error: syntax error, unexpected ':', expecting ';' or '{', telling me to fix the errors and resubmit.

Implementing the interface without compatible return types won't work.

Releasing 2 different versions (2.3 & <2.3) and supporting them wouldn't be wise, given that CsrfAwareActionInterface would be the sole difference between them.

Is the result of that test (code sniffer) breaking? Can an extension be approved despite that test failing?

extensions magento2.3 marketplace

share|improve this question

edited Jun 9 at 12:10

Ravenous

asked Jun 9 at 11:54

RavenousRavenous

1011

New contributor

Ravenous is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$part = interface_exists('MagentoFrameworkAppCsrfAwareActionInterface') ? 'new' : 'old';
include_once sprintf('a/b/c/d+%s.php', $part);

share|improve this question

edited Jun 9 at 12:10

Ravenous

asked Jun 9 at 11:54

RavenousRavenous

1011

New contributor

Ravenous is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

share|improve this question

edited Jun 9 at 12:10

Ravenous

asked Jun 9 at 11:54

RavenousRavenous

1011

New contributor

Ravenous is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked Jun 9 at 11:54

RavenousRavenous

1011

New contributor

Ravenous is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked Jun 9 at 11:54

RavenousRavenous

1011